-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2371/
-----------------------------------------------------------
(Updated 2011-10-27 17:38:58.120670)
Review request for hive and Paul Yang.
Changes
-------
I fixed an issue that was causing altering views to fail.
I ran all the test queries and they succeeded.
Summary
-------
I added a whitelist configuration variable, whose value should be a comma
separated list of hosts. A set of strings is created based on this list and
the host name in a location given to a create/alter table/partition command to
the HiveMetastore is compared to the values in that set. If the list is
nonempty, the table being altered/created or containing the partition is not
external/non-native, and the location has an explicit host, the command is
failed if the host is not in that set, otherwise the command continues as
normal.
This addresses bug HIVE-2502.
https://issues.apache.org/jira/browse/HIVE-2502
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1189406
trunk/conf/hive-default.xml 1189406
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
1189406
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1189406
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
1189406
Diff: https://reviews.apache.org/r/2371/diff
Testing
-------
I used Thrift calls to test the following for each of the 4 commands
create/alter table/partition:
Issuing the command with a location with a host that is not in the whitelist
fails.
Issuing the command with a location with a host in the whitelist does not fail.
Thanks,
Kevin
