> On July 14, 2015, 11:06 p.m., Matt McCline wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java, line 667 > > <https://reviews.apache.org/r/36486/diff/1/?file=1011846#file1011846line667> > > > > Why isn't the condition this.hashTblInitedOnce included anymore?
this.hashTblInitedOnce is checked as part of canSkipReload() - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36486/#review91674 ----------------------------------------------------------- On July 14, 2015, 10:09 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36486/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 10:09 p.m.) > > > Review request for hive, Matt McCline, Vikram Dixit Kumaraswamy, and Wei > Zheng. > > > Bugs: HIVE-11262 > https://issues.apache.org/jira/browse/HIVE-11262 > > > Repository: hive-git > > > Description > ------- > > - Added size() method to HashTableContainer interface/implementations. > - After loading hashTable, check if size == 0 and if join is all inner joins. > If so, set done on the MapJoinOperator. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 15cafdd > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java > e338a31 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java > 83a1521 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainer.java > 9d8cbcb > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTable.java > fbe6b4c > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastTableContainer.java > 4b1d6f6 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/hashtable/VectorMapJoinHashTable.java > 7e219ec > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedHashTable.java > a2d4e4c > > Diff: https://reviews.apache.org/r/36486/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
