----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36280/#review91021 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java (line 1212) <https://reviews.apache.org/r/36280/#comment144243> What happens when Table/Part Desc changes (due to alter commands)? Since there is no invalidation mechanisms, caching it in a static map seems bad. Instead may be in the caller pass in TableDesc obj thus reusing it. - John Pullokkaran On July 7, 2015, 9:35 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36280/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 9:35 p.m.) > > > Review request for hive and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > Utilities.getPartitionDesc() should try to reuse TableDesc object > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java afecb1e > ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 08ff2e9 > > Diff: https://reviews.apache.org/r/36280/diff/ > > > Testing > ------- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
