----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36069/#review90502 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java (line 49) <https://reviews.apache.org/r/36069/#comment143613> What about '.', '?', '&&' ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java (line 52) <https://reviews.apache.org/r/36069/#comment143618> Isn't it better to change wildCards to Hashset then use contains? - John Pullokkaran On July 2, 2015, 1:10 a.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36069/ > ----------------------------------------------------------- > > (Updated July 2, 2015, 1:10 a.m.) > > > Review request for hive, John Pullokkaran and Mostafa Mokhtar. > > > Repository: hive-git > > > Description > ------- > > Improve RuleRegExp when the Expression node stack gets huge > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java ddc96c2 > ql/src/test/org/apache/hadoop/hive/ql/lib/TestRuleRegExp.java PRE-CREATION > > Diff: https://reviews.apache.org/r/36069/diff/ > > > Testing > ------- > > Local testing. > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
