----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35964/#review89622 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java (line 79) <https://reviews.apache.org/r/35964/#comment142268> Nit: While this closes bfReader, there is a slim chance that the underlying file reader isn't closed. That's the case where "New FileReader()" is successful while "New BufferedReader()) fails. - Xuefu Zhang On June 27, 2015, 3:44 a.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35964/ > ----------------------------------------------------------- > > (Updated June 27, 2015, 3:44 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-7180 > https://issues.apache.org/jira/browse/HIVE-7180 > > > Repository: hive-git > > > Description > ------- > > HIVE-7180 BufferedReader is not closed in MetaStoreSchemaInfo > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > a5eed6d3c0ff4a229f3209175b8dfcf8bde5e79e > > Diff: https://reviews.apache.org/r/35964/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >
