----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34961/#review88065 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 3513) <https://reviews.apache.org/r/34961/#comment140456> closeAll() call will close the result set. So if you return a List or Collection object (which has iterator interface)d directly from query.execute() returned, we can't iterate later through the list anymore. So we need to iterate through the list here. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 3543) <https://reviews.apache.org/r/34961/#comment140457> Same comments as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4431) <https://reviews.apache.org/r/34961/#comment140458> Same comments as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4460) <https://reviews.apache.org/r/34961/#comment140459> Same comments as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4483) <https://reviews.apache.org/r/34961/#comment140460> Same comments as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4528) <https://reviews.apache.org/r/34961/#comment140461> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4586) <https://reviews.apache.org/r/34961/#comment140462> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4621) <https://reviews.apache.org/r/34961/#comment140463> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4650) <https://reviews.apache.org/r/34961/#comment140464> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4679) <https://reviews.apache.org/r/34961/#comment140465> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4710) <https://reviews.apache.org/r/34961/#comment140466> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4771) <https://reviews.apache.org/r/34961/#comment140467> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4867) <https://reviews.apache.org/r/34961/#comment140468> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4903) <https://reviews.apache.org/r/34961/#comment140469> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4940) <https://reviews.apache.org/r/34961/#comment140470> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4981) <https://reviews.apache.org/r/34961/#comment140471> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 5016) <https://reviews.apache.org/r/34961/#comment140472> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 5050) <https://reviews.apache.org/r/34961/#comment140473> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 5126) <https://reviews.apache.org/r/34961/#comment140474> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 5158) <https://reviews.apache.org/r/34961/#comment140475> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 5355) <https://reviews.apache.org/r/34961/#comment140478> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 5386) <https://reviews.apache.org/r/34961/#comment140477> Same comment as above. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 5436) <https://reviews.apache.org/r/34961/#comment140476> Same comment as above. - Aihua Xu On June 2, 2015, 11:07 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34961/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 11:07 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-10895 > https://issues.apache.org/jira/browse/HIVE-10895 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-10895 > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > fd61333 > > Diff: https://reviews.apache.org/r/34961/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
