----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35218/#review87097 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java <https://reviews.apache.org/r/35218/#comment139388> Nit : Can you do these initializations in default constructor? That way these objects are created only when class is instantiated as oppose as soon as it is loaded by class loader. ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java <https://reviews.apache.org/r/35218/#comment139389> It will be good to add PartitionSpec as well as WindowFrameSpec in toString() (with null checks) - Ashutosh Chauhan On June 8, 2015, 6:33 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35218/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 6:33 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-10963 Hive throws NPE rather than meaningful error message when window > is missing > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java > 953f3ae8ab583e2a7be28a0f1a05871f38c09d58 > ql/src/test/queries/clientnegative/ptf_negative_NoWindowDefn.q PRE-CREATION > ql/src/test/results/clientnegative/ptf_negative_NoWindowDefn.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/35218/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
