> > ... we should put the commit log in the corresponding > JIRA comment as a cross-reference. >
I've only noticed one more slip-up since the end of April, but still think this is a good idea. Any more suggestions? -- Lefty On Thu, Apr 30, 2015 at 4:53 PM, Xuefu Zhang <xzh...@cloudera.com> wrote: > Yes, for that, I think we should put the commit log in the corresponding > JIRA comment as a cross-reference. I have to admit that I had to fix commit > message for a few of my svn commits in the past. > > On Thu, Apr 30, 2015 at 3:53 PM, Lefty Leverenz <leftylever...@gmail.com> > wrote: > > > Found a negative answer to #2 in some ASF instructions > > <http://www.apache.org/security/committers.html> for security issues > > (*underline > > added*): > > > > 15. The log for the svn commit that applied the fix is updated to > include > > > the CVE number. Projects that use git as their primary source code > > control > > > system should not do this as *editing a pushed commit causes all sorts > of > > > problems*. > > > > > > All the more reason to be careful about the JIRA number when you commit a > > patch. > > > > > > -- Lefty > > > > On Thu, Apr 30, 2015 at 2:57 AM, Lefty Leverenz <leftylever...@gmail.com > > > > wrote: > > > > > Since switching to git, three commits have had the wrong JIRA number. > > Two > > > were typos and the third one gave the umbrella issue's number. > > Fortunately > > > the correct issue could be found by searching for the summary text. > > > > > > 1. How can we reduce this failure rate? > > > 2. Can JIRA numbers be fixed after-the-fact in commit records? > > > 3. Should JIRA issues track commit IDs? > > > > > > -- Lefty > > > > > >
