----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35136/#review86824 -----------------------------------------------------------
data/files/emp2.txt <https://reviews.apache.org/r/35136/#comment138919> Can you add few rows with NULL value for date column? Want to make sure DateValueBoundaryScanner.isGreater() and isEqual() methods are null resilient. - Ashutosh Chauhan On June 5, 2015, 3:46 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35136/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 3:46 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-10911 Add support for date datatype in the value based windowing function > > > Diffs > ----- > > data/files/emp2.txt PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java > c1b8a1dc42fc8a70fa1ece609f85f9cffe6795d4 > ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java > 40fd6a459a733bc465afe6108a184f2e8abf1a7d > ql/src/test/queries/clientpositive/windowing_windowspec3.q PRE-CREATION > ql/src/test/results/clientpositive/windowing_windowspec3.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/35136/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
