----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34393/#review84749 -----------------------------------------------------------
ql/src/test/queries/clientpositive/udaf_collect_set_2.q <https://reviews.apache.org/r/34393/#comment136097> Is it necessary? - Alexander Pivovarov On May 21, 2015, 5:30 p.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34393/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 5:30 p.m.) > > > Review request for hive. > > > Bugs: HIVE-10427 > https://issues.apache.org/jira/browse/HIVE-10427 > > > Repository: hive-git > > > Description > ------- > > Currently for collect_list() and collect_set(), only primitive types are > supported. This patch adds support for struct, list and map types as well. > > It turned out I that all I need is loosen the type checking. > > > Diffs > ----- > > data/files/customers.txt PRE-CREATION > data/files/nested_orders.txt PRE-CREATION > data/files/orders.txt PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectList.java > 536c4a7 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectSet.java > 6dc424a > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java > efcc8f5 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java > 2d6d58c > ql/src/test/queries/clientnegative/udaf_collect_set_unsupported.q > PRE-CREATION > ql/src/test/queries/clientnegative/udf_sort_array_wrong3.q 034de06 > ql/src/test/queries/clientpositive/udaf_collect_set_2.q PRE-CREATION > ql/src/test/results/clientnegative/udaf_collect_set_unsupported.q.out > PRE-CREATION > ql/src/test/results/clientnegative/udf_sort_array_wrong2.q.out c068ecd > ql/src/test/results/clientpositive/udaf_collect_set_2.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/34393/diff/ > > > Testing > ------- > > All but one test (which seems unrelated) are passing. > I also added a test: udaf_collect_list_set_2.q > > > Thanks, > > Chao Sun > >
