> On May 18, 2015, 2:26 a.m., chengxiang li wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java, > > line 96 > > <https://reviews.apache.org/r/34293/diff/1/?file=961679#file961679line96> > > > > SparkClientFactory.initialize would be invoked only once, which means > > RpcServer would be initialized once inside either, so while we update spark > > client rpc related paramters, RpcServer does not really updated. This > > should be another issue, i just list here as it's found while read the code.
Are you saying the RpcServer should be restated too, because some configuration used by RpcServer could be changed? We may need to track those related properties separately. This could complicate the code however. Of course, I agree with you this is indeed an issue. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34293/#review84094 ----------------------------------------------------------- On May 15, 2015, 9:53 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34293/ > ----------------------------------------------------------- > > (Updated May 15, 2015, 9:53 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-10721 > https://issues.apache.org/jira/browse/HIVE-10721 > > > Repository: hive-git > > > Description > ------- > > Add a SparkSession to createdSessions only after the session is opened > properly if doOpen is specified. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > 7e33a3f > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java > bae30f3 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > 603f1ca > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java > ad012b6 > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java > 1bcd221 > > Diff: https://reviews.apache.org/r/34293/diff/ > > > Testing > ------- > > > Thanks, > > Jimmy Xiang > >
