> On May 12, 2015, 5:51 a.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java, line 674 > > <https://reviews.apache.org/r/34059/diff/1/?file=955661#file955661line674> > > > > I think it's better to use Map.Entry here to avoid unnecessary lookup > > "get(pos)" > > Map.Entry provides getKey, getValue, setValue methods.
will fix > On May 12, 2015, 5:51 a.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java, line 679 > > <https://reviews.apache.org/r/34059/diff/1/?file=955661#file955661line679> > > > > the same recommendation as avove will fix > On May 12, 2015, 5:51 a.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java, line 715 > > <https://reviews.apache.org/r/34059/diff/1/?file=955661#file955661line715> > > > > Using replace(char, char) is faster than replace(CharSequence target, > > CharSequence replacement) because it is not using > > Pattern.compile().matcher().replaceAll API > > > > Can you use replace('.', '_') instead of replace(".", "_")? will fix - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34059/#review83356 ----------------------------------------------------------- On May 11, 2015, 9:48 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34059/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 9:48 p.m.) > > > Review request for hive, Matt McCline and Vikram Dixit Kumaraswamy. > > > Bugs: HIVE-10673 > https://issues.apache.org/jira/browse/HIVE-10673 > > > Repository: hive-git > > > Description > ------- > > Reduce-side hash join (using MapJoinOperator), where the Tez inputs to the > reducer are unsorted. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java eff4d30 > itests/src/test/resources/testconfiguration.properties eeb46cc > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java b1352f3 > ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java d7f1b42 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KeyValuesAdapter.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KeyValuesFromKeyValue.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KeyValuesFromKeyValues.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java > 545d7c6 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java > cdabe3a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java > 15c747e > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java > a9082eb > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java > d42b643 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java > 4d84f0f > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java > f7e1dbc > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezProcContext.java adc31ae > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 241e9d7 > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezWork.java 6db8220 > ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java a342738 > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java fb3c4a3 > ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java cee9100 > ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_1.q PRE-CREATION > ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_2.q PRE-CREATION > ql/src/test/queries/clientpositive/tez_vector_dynpart_hashjoin_1.q > PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_vector_dynpart_hashjoin_1.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/34059/diff/ > > > Testing > ------- > > q-file tests added > > > Thanks, > > Jason Dere > >
