----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33881/#review83635 -----------------------------------------------------------
beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java <https://reviews.apache.org/r/33881/#comment134645> UPPERCASE variables are constants in java. static final beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java <https://reviews.apache.org/r/33881/#comment134643> move bw.close() to finally block - Alexander Pivovarov On May 11, 2015, 3:22 p.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33881/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 3:22 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-10623 > https://issues.apache.org/jira/browse/HIVE-10623 > > > Repository: hive-git > > > Description > ------- > > Changes: > 1. Support the hive cli options including database, e, !, H, f. > 2. Add error handler for using f and e together > 3. Add error handler for invalid option > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java b3d89cb > beeline/src/java/org/apache/hive/beeline/cli/CliOptionsProcessor.java > PRE-CREATION > beeline/src/java/org/apache/hive/beeline/cli/HiveCli.java PRE-CREATION > beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java PRE-CREATION > > Diff: https://reviews.apache.org/r/33881/diff/ > > > Testing > ------- > > Newly add unit test passed locally. > > > Thanks, > > cheng xu > >
