I'm fine with doing this for the release, but I think we should apply the fix to branch-1.2 after the release so that any subsequent patches applied to this branch don't have to deal with the failing tests.

Alan.

Sushanth Sowmyan <mailto:khorg...@gmail.com>
May 11, 2015 at 12:01
Thanks for the catch, Alan.

Looks like the 2 jars got added via HIVE-9302, and are being used as resources for beeline tests. We could attempt to change the postgres jar to a download, but I don't know where the DummyDriver is coming from. They really should not have been checked in, imo.

(we should have it compiled and placed in there as a test-dependency if it is being generated)

That said, given that those are bigger changes, I would like to propose that we fix this issue in the proper way in master to remove the jars (by adding download/test-compile steps as appropriate), and for branch-1.2, we simply remove these jars so that the tests can fail if need be. Thoughts, Alan/Xuefu?

--

Not sure I understand what you're asking for @VERSION@ ? I replaced it with 1.2.0 for branch-1.2, so the text version does have it?
Re: Runtimes : True, I'll add spark in that list. -- I'll update this.
Re: JDK1.6 : Also true, we no longer compile under jdk 1.6 (I just verified that was the case) -- I'll update this



Alan Gates <mailto:alanfga...@gmail.com>
May 11, 2015 at 10:51
-1

A couple of jar files found there way into the src release:
gates> find . -name \*.jar
./beeline/src/test/resources/DummyDriver-1.0-SNAPSHOT.jar
./beeline/src/test/resources/postgresql-9.3.jdbc3.jar

We can't have any binaries in the source release.

In the README:
* At what point is the @VERSION@ string supposed to be replaced? The text version should include an actual version number. * It's no longer true the Hive allows the choice of 2 runtimes, it now has 3. * Does Hive 1.2 run on Java 1.6? I thought we switched this release to require 1.7.

The release notes don't appear to include a list of fixed JIRAs for 1.2, the last set of JIRAs is 1.1.

Alan.

Sushanth Sowmyan <mailto:khorg...@gmail.com>
May 11, 2015 at 10:14
Hi Folks,

We've cleared all the blockers listed for 1.2.0 release, either
committing them, or deferring out to an eventual 1.2.1 stabilization
release. (Any deferrals were a result of discussion between myself and
the committer responsible for the issue.) More details are available
here : https://cwiki.apache.org/confluence/display/Hive/Hive+1.2+Release+Status

Apache Hive 1.2.0 Release Candidate 2 is available here:

https://people.apache.org/~khorgath/releases/1.2.0_RC2/artifacts/

My public key used for signing is as available from the hive
committers key list : http://www.apache.org/dist/hive/KEYS

Maven artifacts are available here:

https://repository.apache.org/content/repositories/orgapachehive-1031

Source tag for RC0 is up on the apache git repo as tag
"release-1.2.0-rc2" (Browseable view over at
https://git-wip-us.apache.org/repos/asf?p=hive.git;a=tag;h=8858fed41d868efe2d60d3605f1560f70e85d4e8
)

Voting will conclude in 72 hours.

Hive PMC Members: Please test and vote.

Thanks,
-Sushanth

Reply via email to