----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33890/#review82789 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/33890/#comment133607> Can you add the new properties in ./build/dist/conf/hive-default.xml.template with description ? service/src/java/org/apache/hive/service/cli/session/SessionManager.java <https://reviews.apache.org/r/33890/#comment133603> Can we pass all the params passed for HiveSessionImplwithUGI here as well ? service/src/java/org/apache/hive/service/cli/session/SessionManager.java <https://reviews.apache.org/r/33890/#comment133604> Same as above, Can we all params passed for HiveSessionImpl here as well? It is fine if implementations want to ignore some, but passing less will be a gap. service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java <https://reviews.apache.org/r/33890/#comment133606> Can you get the session object from service and assert it is an instance of TestHiveSessionImpl ? service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java <https://reviews.apache.org/r/33890/#comment133605> I dont see the constructor added with params expected, are you sure the test is passing fine? - Amareshwari Sriramadasu On May 6, 2015, 12:29 p.m., Akshay Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33890/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 12:29 p.m.) > > > Review request for hive and Amareshwari Sriramadasu. > > > Bugs: HIVE-10435 > https://issues.apache.org/jira/browse/HIVE-10435 > > > Repository: hive-git > > > Description > ------- > > SessionManager in CLIService creates and keeps track of HiveSession. > Right now, it creates HiveSessionImpl which is one implementation of > HiveSession. This improvement request is to make it pluggable through a > configuration so that other implementations can be passed. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 69fda45 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 36a30b1 > > service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33890/diff/ > > > Testing > ------- > > Newly added unit test passed. > > > Thanks, > > Akshay Goyal > >
