----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33814/#review82652 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java <https://reviews.apache.org/r/33814/#comment133430> stray import? ql/src/test/results/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out <https://reviews.apache.org/r/33814/#comment133429> This seems rather strange, since the rows are still being read (i.e select 1 from lineitem_ix will return 3024 rows). Is this a stats mismatch due to this patch? - Gopal V On May 6, 2015, 6:35 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33814/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 6:35 a.m.) > > > Review request for hive and Gopal V. > > > Bugs: HIVE-9644 > https://issues.apache.org/jira/browse/HIVE-9644 > > > Repository: hive-git > > > Description > ------- > > CASE comparison operator rotation optimization > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java > e9436e5 > ql/src/test/queries/clientpositive/fold_case.q PRE-CREATION > ql/src/test/queries/clientpositive/fold_when.q PRE-CREATION > ql/src/test/results/clientpositive/fold_case.q.out PRE-CREATION > ql/src/test/results/clientpositive/fold_when.q.out PRE-CREATION > ql/src/test/results/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out 6340a75 > > Diff: https://reviews.apache.org/r/33814/diff/ > > > Testing > ------- > > New tests added. > > > Thanks, > > Ashutosh Chauhan > >