----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/#review81103 -----------------------------------------------------------
spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java <https://reviews.apache.org/r/33422/#comment131349> This will throw an exception if the child process exits with a non-zero status after the RSC connects back to HS2. I don't think you want that. spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java <https://reviews.apache.org/r/33422/#comment131351> While the only current call site reflects the error message, this method seems more generic than that. Maybe pass the error message as a parameter to the method? - Marcelo Vanzin On April 22, 2015, 12:30 a.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33422/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 12:30 a.m.) > > > Review request for hive and Marcelo Vanzin. > > > Bugs: HIVE-10434 > https://issues.apache.org/jira/browse/HIVE-10434 > > > Repository: hive-git > > > Description > ------- > > This patch cancels the connection from HS2 to remote process once the latter > has failed and exited with error code, to > avoid potential long timeout. > It add a new public method cancelClient to the RpcServer class - not sure > whether there's an easier way to do this.. > > > Diffs > ----- > > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java > 71e432d > spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java > 32d4c46 > > Diff: https://reviews.apache.org/r/33422/diff/ > > > Testing > ------- > > Tested on my own cluster, and it worked. > > > Thanks, > > Chao Sun > >
