----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33299/#review80658 -----------------------------------------------------------
LGTM, just one suggestion. itests/qtest/pom.xml <https://reviews.apache.org/r/33299/#comment130788> I think we might add the required java classes in the itest project and use it in qtest from maven installation folder. Just one suggestion. - cheng xu On April 17, 2015, 11:12 a.m., Anant Nag wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33299/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 11:12 a.m.) > > > Review request for hive. > > > Bugs: HIVE-10376 > https://issues.apache.org/jira/browse/HIVE-10376 > > > Repository: hive-git > > > Description > ------- > > Currently the code to create an example jar for ivyDownload.q is piggybanked > on the download-spark ant-run-plugin id. This code should be moved to a > separate execution id called something like "create-ivytest-jar" or more > generally "itests-setup". > > > Diffs > ----- > > itests/pom.xml 6f6cf742c41a11647589692ac4f266f467be2812 > itests/qtest/pom.xml 1c3f74c113df4c1d45664f68098ec428666e1d3e > > Diff: https://reviews.apache.org/r/33299/diff/ > > > Testing > ------- > > > Thanks, > > Anant Nag > >
