----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33186/ -----------------------------------------------------------
(Updated April 15, 2015, 8:38 p.m.) Review request for hive, Gunther Hagleitner and Xuefu Zhang. Changes ------- For Patch v5 I have refactored it so both BinarySortableSerDe and BinarySortableSerializeWrite both call into the same common logic, and updated the tests for TestBinarySortableFast, similar to TestBinarySortableSerDe. Bugs: HIVE-10270 https://issues.apache.org/jira/browse/HIVE-10270 Repository: hive-git Description ------- Change HiveDecimal.precision() to return the SQL precision rather than BigDecimal.precision() Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java c2bf6d7 ql/src/test/queries/clientpositive/decimal_precision2.q PRE-CREATION ql/src/test/results/clientpositive/decimal_precision2.q.out PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java a6ab7a7 serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/fast/BinarySortableSerializeWrite.java f62def8 serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestClass.java 370e857 serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestPrimitiveClass.java 2e2327b serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableFast.java 83d3839 serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java b3fb3be Diff: https://reviews.apache.org/r/33186/diff/ Testing ------- Thanks, Jason Dere