Review Request 33128: HIVE-10313:Literal Decimal ExprNodeConstantDesc should contain value of HiveDecimal instead of String

[Chaoyu Tang]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33128/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan, Szehon Ho, and Xuefu Zhang.


Bugs: HIVE-10313
    https://issues.apache.org/jira/browse/HIVE-10313


Repository: hive-git


Description
-------

In TyepCheckProcFactory.NumExprProcessor, the ExprNodeConstantDesc is currently 
created from strVal:
==
else if (expr.getText().endsWith("BD")) {
          // Literal decimal
          String strVal = expr.getText().substring(0, expr.getText().length() - 
2);
          HiveDecimal hd = HiveDecimal.create(strVal);
          int prec = 1;
          int scale = 0;
          if (hd != null) {
            prec = hd.precision();
            scale = hd.scale();
          }
          DecimalTypeInfo typeInfo = TypeInfoFactory.getDecimalTypeInfo(prec, 
scale);
          return new ExprNodeConstantDesc(typeInfo, strVal);
        } 
==
It shoudl be created from HiveDecimal hd instread.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 79d38bc 
  ql/src/test/results/clientpositive/literal_decimal.q.out b2a23cf 

Diff: https://reviews.apache.org/r/33128/diff/


Testing
-------

Manually tests
kick off precommit build tests


Thanks,

Chaoyu Tang