> On April 7, 2015, 4:19 a.m., Swarnim Kulkarni wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java, > > line 1347 > > <https://reviews.apache.org/r/32901/diff/1/?file=918312#file918312line1347> > > > > Nit: Else not needed.
The new patch will look a bit different, so this will not be needed. > On April 7, 2015, 4:19 a.m., Swarnim Kulkarni wrote: > > ql/src/test/results/clientpositive/compute_stats_date.q.out, line 110 > > <https://reviews.apache.org/r/32901/diff/1/?file=918314#file918314line110> > > > > Getting rid of the tabs here would be nice. This is query output generated by Hive, the tabs are expected here as column output delimiters. > On April 7, 2015, 4:19 a.m., Swarnim Kulkarni wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java, > > line 1341 > > <https://reviews.apache.org/r/32901/diff/1/?file=918312#file918312line1341> > > > > Would it be a little safer here to assert that "parameters" has atleast > > 2 values in it so that we do not fail with an > > ArrayIndexOutOfBoundsException? GenericUDAFComputeStats.getEvaluator(), which instantiates the various StatsEvaluators, is already doing the initial checking of the array size. The other StatsEvaluators for the other types are relying on this as well. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32901/#review79119 ----------------------------------------------------------- On April 6, 2015, 9:01 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32901/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 9:01 p.m.) > > > Review request for hive, Ashutosh Chauhan and Prasanth_J. > > > Bugs: HIVE-10226 > https://issues.apache.org/jira/browse/HIVE-10226 > > > Repository: hive-git > > > Description > ------- > > Re-use the long stats for Date column stats, using the days since epoch value > as the long value. > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java > 475883b > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 0c46b00 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java > 363039b > ql/src/test/queries/clientpositive/compute_stats_date.q PRE-CREATION > ql/src/test/results/clientpositive/compute_stats_date.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/32901/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
