[ https://issues.apache.org/jira/browse/HIVE-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133062#comment-13133062 ]
jirapos...@reviews.apache.org commented on HIVE-2496: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2521/#review2760 ----------------------------------------------------------- ql/src/test/queries/clientpositive/alter_rename.q <https://reviews.apache.org/r/2521/#comment6201> You need to inject some data into the table and verify that you can still query this data after changing the db/name of the table. If you add this test I think you're going to discover that there's a bug. - Carl On 2011-10-21 20:56:46, Jonathan Natkins wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2521/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-10-21 20:56:46) bq. bq. bq. Review request for hive. bq. bq. bq. Summary bq. ------- bq. bq. This modifies the syntax of ALTER TABLE RENAME slightly, to allow for specifying qualified names. bq. bq. bq. This addresses bug HIVE-2496. bq. https://issues.apache.org/jira/browse/HIVE-2496 bq. bq. bq. Diffs bq. ----- bq. bq. metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java bd8be04 bq. ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 974b326 bq. ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java a9a0cd8 bq. ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 6698240 bq. ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 82274de bq. ql/src/test/queries/clientnegative/alter_rename1.q PRE-CREATION bq. ql/src/test/queries/clientnegative/alter_rename2.q PRE-CREATION bq. ql/src/test/queries/clientpositive/alter_rename.q PRE-CREATION bq. ql/src/test/results/clientnegative/alter_rename1.q.out PRE-CREATION bq. ql/src/test/results/clientnegative/alter_rename2.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/alter_rename.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/input3.q.out 1017745 bq. bq. Diff: https://reviews.apache.org/r/2521/diff bq. bq. bq. Testing bq. ------- bq. bq. Automated tests added, and ran test suite bq. bq. bq. Thanks, bq. bq. Jonathan bq. bq. > Allow ALTER TABLE RENAME between schemas > ---------------------------------------- > > Key: HIVE-2496 > URL: https://issues.apache.org/jira/browse/HIVE-2496 > Project: Hive > Issue Type: New Feature > Components: Metastore > Reporter: Patrick Angeles > Assignee: Jonathan Natkins > Attachments: HIVE-2496.1.patch, HIVE-2496.2.patch > > > Currently, this is not allowed which is unfortunate: > ALTER TABLE db1.foo RENAME TO db2.foo ; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira