----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2521/#review2760 -----------------------------------------------------------
ql/src/test/queries/clientpositive/alter_rename.q <https://reviews.apache.org/r/2521/#comment6201> You need to inject some data into the table and verify that you can still query this data after changing the db/name of the table. If you add this test I think you're going to discover that there's a bug. - Carl On 2011-10-21 20:56:46, Jonathan Natkins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2521/ > ----------------------------------------------------------- > > (Updated 2011-10-21 20:56:46) > > > Review request for hive. > > > Summary > ------- > > This modifies the syntax of ALTER TABLE RENAME slightly, to allow for > specifying qualified names. > > > This addresses bug HIVE-2496. > https://issues.apache.org/jira/browse/HIVE-2496 > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > bd8be04 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 974b326 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > a9a0cd8 > ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 6698240 > ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 82274de > ql/src/test/queries/clientnegative/alter_rename1.q PRE-CREATION > ql/src/test/queries/clientnegative/alter_rename2.q PRE-CREATION > ql/src/test/queries/clientpositive/alter_rename.q PRE-CREATION > ql/src/test/results/clientnegative/alter_rename1.q.out PRE-CREATION > ql/src/test/results/clientnegative/alter_rename2.q.out PRE-CREATION > ql/src/test/results/clientpositive/alter_rename.q.out PRE-CREATION > ql/src/test/results/clientpositive/input3.q.out 1017745 > > Diff: https://reviews.apache.org/r/2521/diff > > > Testing > ------- > > Automated tests added, and ran test suite > > > Thanks, > > Jonathan > >
