----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31395/ -----------------------------------------------------------
Review request for hive. Repository: hive-git Description ------- When org.apache.thrift.transport.TTransportException is thrown for issues like socket timeout, the retry via RetryingMetaStoreClient happens only in certain cases. Retry happens for the getDatabase call in but not for getAllDatabases(). The reason is RetryingMetaStoreClient checks for TTransportException being the cause for InvocationTargetException. But in case of some calls such as getAllDatabases in HiveMetastoreClient, all exceptions get wrapped in a MetaException. We should remove this unnecessary wrapping of exceptions for certain functions in HMC. Diffs ----- metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java b4f02fc Diff: https://reviews.apache.org/r/31395/diff/ Testing ------- Thanks, XIAOBING ZHOU
