[ https://issues.apache.org/jira/browse/HIVE-9671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332211#comment-14332211 ]
Xuefu Zhang commented on HIVE-9671: ----------------------------------- Patch looks good. On minor nit: one space seems missing: {code} user =Utils.getUGI().getShortUserName(); {code} Besides that, the code additions in shim seem identical, so it might make sense to have a private method to reuse the code instead. > Support Impersonation [Spark Branch] > ------------------------------------ > > Key: HIVE-9671 > URL: https://issues.apache.org/jira/browse/HIVE-9671 > Project: Hive > Issue Type: Sub-task > Components: Spark > Affects Versions: spark-branch > Reporter: Brock Noland > Assignee: Brock Noland > Attachments: HIVE-9671.1-spark.patch, HIVE-9671.1-spark.patch, > HIVE-9671.2-spark.patch > > > SPARK-5493 in 1.3 implemented proxy user authentication. We need to implement > using this option in spark client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)