[
https://issues.apache.org/jira/browse/HIVE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329458#comment-14329458
]
Lars Francke commented on HIVE-8342:
------------------------------------
Ted, thanks for the reminder.
Looks mostly good. I'd suggest
{code}
if (conf == null) {
throw new HiveException("FileSinkDesc cannot be null");
}
{code}
instead. Adheres to coding standard and removes extra period at the end of the
message.
The only problem with this patch is that
{{AbstractFileMergeOperator#jobCloseOp}} calls the method {{mvFileToFinalPath}}
with {{null}}. I didn't follow the code to see if if this can actually happen
though.
> Potential null dereference in ColumnTruncateMapper#jobClose()
> -------------------------------------------------------------
>
> Key: HIVE-8342
> URL: https://issues.apache.org/jira/browse/HIVE-8342
> Project: Hive
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: skrho
> Priority: Minor
> Attachments: HIVE-8342_001.patch, HIVE-8342_002.patch
>
>
> {code}
> Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx,
> null,
> reporter);
> {code}
> Utilities.mvFileToFinalPath() calls createEmptyBuckets() where conf is
> dereferenced:
> {code}
> boolean isCompressed = conf.getCompressed();
> TableDesc tableInfo = conf.getTableInfo();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
