----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review73240 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java <https://reviews.apache.org/r/30335/#comment119516> In 99% of the cases arg[1] will be constant you can get arg[1] avalue in initialize() instead of doing it in evaluate() for each row if (arguments[1] instanceof ConstantObjectInspector) { String fmt = ((ConstantObjectInspector) arguments[1]).getWritableConstantValue() .toString(); } ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java <https://reviews.apache.org/r/30335/#comment119517> use {} always ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java <https://reviews.apache.org/r/30335/#comment119518> base class GenericUDF has getStandardDisplayString() implementation already. - Alexander Pivovarov On Feb. 20, 2015, 1:18 a.m., XIAOBING ZHOU wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30335/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 1:18 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > Hive already supports LAST_DAY UDF, in some cases, FIRST_DAY is necessary to > do date/timestamp related computation. This JIRA is to track such an > implementation. > > https://issues.apache.org/jira/browse/HIVE-9480 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfb4dc2 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFTrunc.java > PRE-CREATION > ql/src/test/queries/clientnegative/udf_trunc_error1.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_trunc_error2.q PRE-CREATION > ql/src/test/queries/clientpositive/udf_trunc.q PRE-CREATION > ql/src/test/results/clientnegative/udf_trunc_error1.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_trunc_error2.q.out PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out e21b54b > ql/src/test/results/clientpositive/udf_trunc.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/30335/diff/ > > > Testing > ------- > > Unit tests done in > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFFirstDay.java > > > Thanks, > > XIAOBING ZHOU > >
