----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31033/ -----------------------------------------------------------
(Updated Feb. 15, 2015, 12:50 a.m.) Review request for hive. Changes ------- Made a couple of changes to how RexConverter determines numeric type, which allowed the TestCliDriver failures to pass. Bugs: HIVE-9690 https://issues.apache.org/jira/browse/HIVE-9690 Repository: hive-git Description ------- Moves GenericUDFOPPlus/GenericUDFOPMinus to GenericUDFOPNumericPlus/GenericUDFOPNumericMinus and adds new GenericUDFOPPlus/GenericUDFOPMinus as wrapper UDFs. Keeps the vectorization annotations in GenericUDFOPPlus/GenericUDFOPMinus. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java 58f89c5 ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 26dec47 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseArithmetic.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseBinary.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java 5c00d36 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java 1daf57e ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java 7e225ff ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNumericMinus.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNumericPlus.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java 2721e6b Diff: https://reviews.apache.org/r/31033/diff/ Testing ------- Thanks, Jason Dere