----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30789/#review72465 -----------------------------------------------------------
Ship it! ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java <https://reviews.apache.org/r/30789/#comment118534> Slight behaviour change, but mod 2 == 1 vs mod 2 != 0 matters only for -ve numbers. But that is already taken care of in generateHash. - Gopal V On Feb. 11, 2015, 9:11 p.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30789/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 9:11 p.m.) > > > Review request for hive, Gopal V and Jason Dere. > > > Bugs: HIVE-9619 > https://issues.apache.org/jira/browse/HIVE-9619 > > > Repository: hive-git > > > Description > ------- > > HIVE-9619 Uninitialized read of numBitVectors in NumDistinctValueEstimator > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java > 2817044039928f9ce94d542a0a6e32970b7d082c > > Diff: https://reviews.apache.org/r/30789/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >
