----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30909/#review72106 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/30909/#comment118050> Why serialize here, would a string of comma-separated values work? ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/30909/#comment118049> Just make sure none of these methods need to get called during the map/reduce tasks, since hive-metastore.jar (and thus the ResourceUri class) is not shipped during the map/reduce tasks. Might want to check this on a cluster just to make sure. - Jason Dere On Feb. 12, 2015, 1:49 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30909/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 1:49 a.m.) > > > Review request for hive, Brock Noland, Dong Chen, Mohit Sabharwal, and Sergio > Pena. > > > Repository: hive-git > > > Description > ------- > > Changes includes: > 1.Update the DDLTask to support using statement > 2.Serialize the resource uri into table properties > 3.Deserialize the resource uri and add them to the session classloader > 4.Some query test and unit tests added > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 062e520 > itests/test-serde/pom.xml cb79072 > > itests/test-serde/src/main/java/org/apache/hadoop/hive/storagehandler/TestBase64TextOutputFormat.java > PRE-CREATION > > itests/test-serde/src/main/java/org/apache/hadoop/hive/storagehandler/TestStorageHandler.java > PRE-CREATION > metastore/if/hive_metastore.thrift c2a2419 > metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.h 35a8a50 > metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.cpp c7bf9ba > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/hive_metastoreConstants.java > 0f2fca8 > metastore/src/gen/thrift/gen-php/metastore/Types.php e8afe4d > metastore/src/gen/thrift/gen-py/hive_metastore/constants.py 81f70eb > metastore/src/gen/thrift/gen-rb/hive_metastore_constants.rb 3208ecd > > metastore/src/model/org/apache/hadoop/hive/metastore/model/MStorageDescriptor.java > 9da3071 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 089bd94 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 569c125 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7d72783 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c4633f6 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 69a4545 > ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java > 1ef6d1b > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 149b788 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java bdb9204 > ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java 7723430 > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 8cadb96 > ql/src/java/org/apache/hadoop/hive/ql/util/SemanticAnalyzerHelper.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java 69f8889 > ql/src/test/org/apache/hadoop/hive/ql/exec/persistence/KryoHiveTest.java > PRE-CREATION > ql/src/test/queries/clientpositive/storage_handler_link_external_jar.q > PRE-CREATION > ql/src/test/results/clientpositive/storage_handler_link_external_jar.q.out > PRE-CREATION > > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java > dda3c5f > > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java > ff0c1f2 > > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java > fba49e4 > > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/PropValueUnion.java > a50a508 > > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/SetIntString.java > 334d225 > > Diff: https://reviews.apache.org/r/30909/diff/ > > > Testing > ------- > > newly added UT passed locally > > > Thanks, > > cheng xu > >
