[
https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127151#comment-13127151
]
jirapos...@reviews.apache.org commented on HIVE-2502:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2371/#review2575
-----------------------------------------------------------
Looks good, but can we do host:port combinations instead of just the host?
- Paul
On 2011-10-12 22:48:52, Kevin Wilfong wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2371/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-12 22:48:52)
bq.
bq.
bq. Review request for hive and Paul Yang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I added a whitelist configuration variable, whose value should be a comma
separated list of hosts. A set of strings is created based on this list and
the host name in a location given to a create/alter table/partition command to
the HiveMetastore is compared to the values in that set. If the list is
nonempty, the table being altered/created or containing the partition is not
external/non-native, and the location has an explicit host, the command is
failed if the host is not in that set, otherwise the command continues as
normal.
bq.
bq.
bq. This addresses bug HIVE-2502.
bq. https://issues.apache.org/jira/browse/HIVE-2502
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1182505
bq. trunk/conf/hive-default.xml 1182505
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
1182505
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1182505
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
1182505
bq.
bq. Diff: https://reviews.apache.org/r/2371/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I used Thrift calls to test the following for each of the 4 commands
create/alter table/partition:
bq.
bq. Issuing the command with a location with a host that is not in the
whitelist fails.
bq. Issuing the command with a location with a host in the whitelist does not
fail.
bq.
bq.
bq. Thanks,
bq.
bq. Kevin
bq.
bq.
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
> Key: HIVE-2502
> URL: https://issues.apache.org/jira/browse/HIVE-2502
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2502.1.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a
> table/partition to verify that the location is acceptable. The whitelist
> should be empty by default, and should be configurable. The check should
> default to pass if there is no host in the location, or the whitelist is
> empty.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
