[
https://issues.apache.org/jira/browse/HIVE-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302083#comment-14302083
]
Hive QA commented on HIVE-9550:
-------------------------------
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12696000/HIVE-9550.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 7420 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udaf_histogram_numeric
org.apache.hive.hcatalog.templeton.TestWebHCatE2e.getHiveVersion
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2618/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2618/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2618/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12696000 - PreCommit-HIVE-TRUNK-Build
> ObjectStore.getNextNotification() can return events inside
> NotificationEventResponse as null which conflicts with its thrift "required"
> tag
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-9550
> URL: https://issues.apache.org/jira/browse/HIVE-9550
> Project: Hive
> Issue Type: Bug
> Reporter: Sushanth Sowmyan
> Assignee: Sushanth Sowmyan
> Attachments: HIVE-9550.patch
>
>
> Per hive_metastore.thrift, the "events" list inside NotificationEventResponse
> is a required field that cannot be null.
> {code}
> struct NotificationEventResponse {
> 1: required list<NotificationEvent> events,
> }
> {code}
> However, per ObjectStore.java, this events field can be uninitialized if the
> events retrieved from the metastore is empty instead of null:
> {code}
> NotificationEventResponse result = new NotificationEventResponse();
> int maxEvents = rqst.getMaxEvents() > 0 ? rqst.getMaxEvents() :
> Integer.MAX_VALUE;
> int numEvents = 0;
> while (i.hasNext() && numEvents++ < maxEvents) {
> result.addToEvents(translateDbToThrift(i.next()));
> }
> return result;
> {code}
> The fix is simple enough - we need to call result.setEvents(new
> ArrayList<NotificationEvent>()) before we begin the iteration to do
> result.addToEvents(...).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
