----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28109/#review70303 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/28109/#comment115395> how about using seconds instead of milliseconds, most people would not care about the millisecond part. service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/28109/#comment115397> is there a difference between having znodeCreationTimeout=6*20=120 sec and this ? service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/28109/#comment115592> Instead of waiting for 15 seconds, lets use wait+notify or CountDownLatch . CountDownLatch is fewer lines of code, and we would not need a separate boolean. Example - http://stackoverflow.com/questions/14929322/need-to-wait-for-asynchronous-api-callback-before-i-return-from-method-in-java "A CountDownLatch initialized with a count of one serves as a simple on/off latch" - http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/CountDownLatch.html - Thejas Nair On Jan. 27, 2015, 12:27 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28109/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 12:27 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-8890 > https://issues.apache.org/jira/browse/HIVE-8890 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-8890 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b > pom.xml c147d45 > service/pom.xml b9d3a40 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > b6e851a > service/src/java/org/apache/hive/service/server/HiveServer2.java 21025a2 > > Diff: https://reviews.apache.org/r/28109/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
