-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30422/
-----------------------------------------------------------
(Updated Jan. 29, 2015, 11:17 p.m.)
Review request for hive and Gunther Hagleitner.
Changes
-------
golden files update.
Bugs: HIVE-8307
https://issues.apache.org/jira/browse/HIVE-8307
Repository: hive-git
Description
-------
remove comments from serde properties.
Diffs (updated)
-----
itests/test-serde/src/main/java/org/apache/hadoop/hive/serde2/TestSerDe.java
9f7a20a
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
612f927
ql/src/test/results/clientpositive/alter1.q.out c288129
ql/src/test/results/clientpositive/alter_partition_coltype.q.out 7b2960b
ql/src/test/results/clientpositive/analyze_table_null_partition.q.out c7254d1
ql/src/test/results/clientpositive/auto_join_reordering_values.q.out 3204af8
ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out cea9eb5
ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out b696e83
ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out c58fa36
ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out 772ccec
ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out ea7b8ff
ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out 24011a3
ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out 969189f
ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out f458c33
ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out 52a69e8
ql/src/test/results/clientpositive/binary_output_format.q.out a0e8e83
ql/src/test/results/clientpositive/bucket1.q.out 13ec735
ql/src/test/results/clientpositive/bucket2.q.out 32a77c3
ql/src/test/results/clientpositive/bucket3.q.out ff7173e
ql/src/test/results/clientpositive/bucket4.q.out b99d12f
ql/src/test/results/clientpositive/bucket5.q.out 5992d6d
ql/src/test/results/clientpositive/bucket_map_join_1.q.out 69a61d4
ql/src/test/results/clientpositive/bucket_map_join_2.q.out fc55855
ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out 870ecdd
ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out 33f5c46
ql/src/test/results/clientpositive/bucket_map_join_spark3.q.out 067d1ff
ql/src/test/results/clientpositive/bucket_map_join_spark4.q.out be87576
ql/src/test/results/clientpositive/bucketcontext_1.q.out 48e9f10
ql/src/test/results/clientpositive/bucketcontext_2.q.out 695feb1
ql/src/test/results/clientpositive/bucketcontext_3.q.out b3929f3
ql/src/test/results/clientpositive/bucketcontext_4.q.out cd81f9e
ql/src/test/results/clientpositive/bucketcontext_5.q.out ef45b4a
ql/src/test/results/clientpositive/bucketcontext_6.q.out 62edc1d
ql/src/test/results/clientpositive/bucketcontext_7.q.out bd79ff2
ql/src/test/results/clientpositive/bucketcontext_8.q.out b6a9ad2
ql/src/test/results/clientpositive/bucketmapjoin1.q.out b8e4b41
ql/src/test/results/clientpositive/bucketmapjoin10.q.out 493e038
ql/src/test/results/clientpositive/bucketmapjoin11.q.out 3a4b2b5
ql/src/test/results/clientpositive/bucketmapjoin12.q.out 537f19f
ql/src/test/results/clientpositive/bucketmapjoin13.q.out a296197
ql/src/test/results/clientpositive/bucketmapjoin2.q.out a8d9e9d
ql/src/test/results/clientpositive/bucketmapjoin3.q.out c759f05
ql/src/test/results/clientpositive/bucketmapjoin4.q.out f61500c
ql/src/test/results/clientpositive/bucketmapjoin5.q.out 0cb2825
ql/src/test/results/clientpositive/bucketmapjoin7.q.out 1f0bae0
ql/src/test/results/clientpositive/bucketmapjoin8.q.out 6d48156
ql/src/test/results/clientpositive/bucketmapjoin9.q.out 01d7cc9
ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out 6ae127d
ql/src/test/results/clientpositive/bucketmapjoin_negative2.q.out 4c9f54a
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e4c87fa
ql/src/test/results/clientpositive/char_serde.q.out 8f6f8ce
ql/src/test/results/clientpositive/columnstats_partlvl.q.out e431b0f
ql/src/test/results/clientpositive/columnstats_tbllvl.q.out de21af8
ql/src/test/results/clientpositive/combine2.q.out e248b1e
ql/src/test/results/clientpositive/constantPropagateForSubQuery.q.out 271bc0f
ql/src/test/results/clientpositive/ctas.q.out 586a832
ql/src/test/results/clientpositive/date_serde.q.out ff09f70
ql/src/test/results/clientpositive/disable_merge_for_bucketing.q.out 9b058c8
ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out 07ac953
ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out
a209ae9
ql/src/test/results/clientpositive/encrypted/encryption_insert_partition_dynamic.q.out
b6e7b88
ql/src/test/results/clientpositive/encrypted/encryption_insert_partition_static.q.out
fc6d2ae
ql/src/test/results/clientpositive/encrypted/encryption_join_unencrypted_tbl.q.out
99f4c17
ql/src/test/results/clientpositive/extrapolate_part_stats_full.q.out 0f6b15d
ql/src/test/results/clientpositive/extrapolate_part_stats_partial.q.out
1fdeb90
ql/src/test/results/clientpositive/filter_join_breaktask.q.out 3631412
ql/src/test/results/clientpositive/groupby_map_ppr.q.out 71a6578
ql/src/test/results/clientpositive/groupby_map_ppr_multi_distinct.q.out
4414b79
ql/src/test/results/clientpositive/groupby_ppr.q.out 4fdcbfd
ql/src/test/results/clientpositive/groupby_ppr_multi_distinct.q.out cd3454c
ql/src/test/results/clientpositive/groupby_sort_1_23.q.out a2b6425
ql/src/test/results/clientpositive/groupby_sort_6.q.out 4e5c96f
ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 2209466
ql/src/test/results/clientpositive/input23.q.out 0bd543b
ql/src/test/results/clientpositive/input42.q.out 95e8553
ql/src/test/results/clientpositive/input_part1.q.out b71faff
ql/src/test/results/clientpositive/input_part2.q.out 77da2eb
ql/src/test/results/clientpositive/input_part7.q.out 6094f9c
ql/src/test/results/clientpositive/input_part9.q.out 6e60679
ql/src/test/results/clientpositive/join17.q.out 26aabcf
ql/src/test/results/clientpositive/join26.q.out 148479a
ql/src/test/results/clientpositive/join32.q.out 9a24d8c
ql/src/test/results/clientpositive/join32_lessSize.q.out 20858cb
ql/src/test/results/clientpositive/join33.q.out 9a24d8c
ql/src/test/results/clientpositive/join34.q.out a20e49f
ql/src/test/results/clientpositive/join35.q.out 937539c
ql/src/test/results/clientpositive/join9.q.out 8421036
ql/src/test/results/clientpositive/join_filters_overlap.q.out 00ca0e5
ql/src/test/results/clientpositive/join_map_ppr.q.out 349c9f5
ql/src/test/results/clientpositive/list_bucket_dml_1.q.out c5bff33
ql/src/test/results/clientpositive/list_bucket_dml_10.q.java1.7.out cfaadd8
ql/src/test/results/clientpositive/list_bucket_dml_11.q.java1.7.out 6c60367
ql/src/test/results/clientpositive/list_bucket_dml_12.q.java1.7.out 7ed4f70
ql/src/test/results/clientpositive/list_bucket_dml_13.q.java1.7.out 7dfa3c2
ql/src/test/results/clientpositive/list_bucket_dml_14.q.out db38473
ql/src/test/results/clientpositive/list_bucket_dml_2.q.java1.7.out 1696954
ql/src/test/results/clientpositive/list_bucket_dml_3.q.out a5d9316
ql/src/test/results/clientpositive/list_bucket_dml_4.q.java1.7.out d358bde
ql/src/test/results/clientpositive/list_bucket_dml_5.q.java1.7.out e07303d
ql/src/test/results/clientpositive/list_bucket_dml_6.q.java1.7.out 3c4a676
ql/src/test/results/clientpositive/list_bucket_dml_7.q.out bb7a888
ql/src/test/results/clientpositive/list_bucket_dml_8.q.java1.7.out ee3a8cd
ql/src/test/results/clientpositive/list_bucket_dml_9.q.java1.7.out 6367611
ql/src/test/results/clientpositive/list_bucket_query_multiskew_1.q.out
9e6e1a7
ql/src/test/results/clientpositive/list_bucket_query_multiskew_2.q.out
a74e1f5
ql/src/test/results/clientpositive/list_bucket_query_multiskew_3.q.out
29a9bd9
ql/src/test/results/clientpositive/list_bucket_query_oneskew_1.q.out 01f673a
ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 6af6159
ql/src/test/results/clientpositive/list_bucket_query_oneskew_3.q.out 8133f55
ql/src/test/results/clientpositive/load_dyn_part8.q.out 073cf5b
ql/src/test/results/clientpositive/louter_join_ppr.q.out dcc35e1
ql/src/test/results/clientpositive/mapjoin_mapjoin.q.out 6d420da
ql/src/test/results/clientpositive/merge3.q.out 2ca40f4
ql/src/test/results/clientpositive/metadataonly1.q.out ec708b9
ql/src/test/results/clientpositive/optimize_nullscan.q.out 3bc06af
ql/src/test/results/clientpositive/outer_join_ppr.q.java1.7.out 25e549a
ql/src/test/results/clientpositive/pcr.q.out b136e56
ql/src/test/results/clientpositive/ppd_join_filter.q.out b4329e4
ql/src/test/results/clientpositive/ppd_union_view.q.out 5ed89ba
ql/src/test/results/clientpositive/ppd_vc.q.out 4ef9cff
ql/src/test/results/clientpositive/ppr_allchildsarenull.q.out 9c4a537
ql/src/test/results/clientpositive/push_or.q.out 7748cf1
ql/src/test/results/clientpositive/quotedid_tblproperty.q.out ca1dbe6
ql/src/test/results/clientpositive/rand_partitionpruner1.q.out e7ee621
ql/src/test/results/clientpositive/rand_partitionpruner2.q.out d04ad8b
ql/src/test/results/clientpositive/rand_partitionpruner3.q.out 5c0f95c
ql/src/test/results/clientpositive/reduce_deduplicate.q.out 4030782
ql/src/test/results/clientpositive/regexp_extract.q.out f26da69
ql/src/test/results/clientpositive/router_join_ppr.q.out 24b9465
ql/src/test/results/clientpositive/sample1.q.out e838887
ql/src/test/results/clientpositive/sample10.q.out e62620a
ql/src/test/results/clientpositive/sample2.q.out 5b6b0f5
ql/src/test/results/clientpositive/sample4.q.out b39cc2c
ql/src/test/results/clientpositive/sample5.q.out aee535c
ql/src/test/results/clientpositive/sample6.q.out 407c19e
ql/src/test/results/clientpositive/sample7.q.out 986f053
ql/src/test/results/clientpositive/sample8.q.out a032f18
ql/src/test/results/clientpositive/sample9.q.out fb71d47
ql/src/test/results/clientpositive/serde_user_properties.q.out 47af4e8
ql/src/test/results/clientpositive/smb_mapjoin_11.q.out 6edb911
ql/src/test/results/clientpositive/smb_mapjoin_12.q.out e5457dd
ql/src/test/results/clientpositive/smb_mapjoin_13.q.out 93ce83b
ql/src/test/results/clientpositive/smb_mapjoin_15.q.out 90efef8
ql/src/test/results/clientpositive/sort_merge_join_desc_5.q.out 2b17830
ql/src/test/results/clientpositive/sort_merge_join_desc_6.q.out 9221daa
ql/src/test/results/clientpositive/sort_merge_join_desc_7.q.out cf4590c
ql/src/test/results/clientpositive/spark/auto_join_reordering_values.q.out
63d2799
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_1.q.out 8be4230
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out db81850
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_2.q.out 2d1b77c
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_3.q.out 7da4d3d
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_4.q.out 7dddad9f
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_5.q.out 220d310
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_7.q.out be1db6e
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_8.q.out ee5cfd9
ql/src/test/results/clientpositive/spark/bucket2.q.out 5eb28fa
ql/src/test/results/clientpositive/spark/bucket3.q.out 1b1010a
ql/src/test/results/clientpositive/spark/bucket4.q.out 7dd49ac
ql/src/test/results/clientpositive/spark/bucket_map_join_1.q.out 07e96fa
ql/src/test/results/clientpositive/spark/bucket_map_join_2.q.out e9b552b
ql/src/test/results/clientpositive/spark/bucket_map_join_spark1.q.out 6230bef
ql/src/test/results/clientpositive/spark/bucket_map_join_spark2.q.out 1a33625
ql/src/test/results/clientpositive/spark/bucket_map_join_spark3.q.out fed923c
ql/src/test/results/clientpositive/spark/bucket_map_join_spark4.q.out 8b5e8d4
ql/src/test/results/clientpositive/spark/bucketmapjoin1.q.out f6c9149
ql/src/test/results/clientpositive/spark/bucketmapjoin10.q.out c16ef99
ql/src/test/results/clientpositive/spark/bucketmapjoin11.q.out fd32de9
ql/src/test/results/clientpositive/spark/bucketmapjoin12.q.out c5ac610
ql/src/test/results/clientpositive/spark/bucketmapjoin13.q.out 57a1e4e
ql/src/test/results/clientpositive/spark/bucketmapjoin2.q.out d82480e
ql/src/test/results/clientpositive/spark/bucketmapjoin3.q.out 39552c1
ql/src/test/results/clientpositive/spark/bucketmapjoin4.q.out ad2762d
ql/src/test/results/clientpositive/spark/bucketmapjoin5.q.out f7c3d4d
ql/src/test/results/clientpositive/spark/bucketmapjoin7.q.out 1cdcbd5
ql/src/test/results/clientpositive/spark/bucketmapjoin8.q.out 13df3aa
ql/src/test/results/clientpositive/spark/bucketmapjoin9.q.out e2a3474
ql/src/test/results/clientpositive/spark/bucketmapjoin_negative.q.out 031c46c
ql/src/test/results/clientpositive/spark/bucketmapjoin_negative2.q.out
4a8f46d
ql/src/test/results/clientpositive/spark/bucketmapjoin_negative3.q.out
899dd18
ql/src/test/results/clientpositive/spark/ctas.q.out 80a0e3d
ql/src/test/results/clientpositive/spark/disable_merge_for_bucketing.q.out
3864c44
ql/src/test/results/clientpositive/spark/filter_join_breaktask.q.out 286c1c4
ql/src/test/results/clientpositive/spark/groupby_map_ppr.q.out 517e492
ql/src/test/results/clientpositive/spark/groupby_map_ppr_multi_distinct.q.out
d247c25
ql/src/test/results/clientpositive/spark/groupby_ppr.q.out 8bc6105
ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out f80d02b
ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 96eb764
ql/src/test/results/clientpositive/spark/input_part2.q.out 9dbde7d
ql/src/test/results/clientpositive/spark/join17.q.out 4aa2a05
ql/src/test/results/clientpositive/spark/join26.q.out e4d26b2
ql/src/test/results/clientpositive/spark/join32.q.out a9d50b4
ql/src/test/results/clientpositive/spark/join32_lessSize.q.out dac9610
ql/src/test/results/clientpositive/spark/join33.q.out a9d50b4
ql/src/test/results/clientpositive/spark/join34.q.out 2aac051
ql/src/test/results/clientpositive/spark/join35.q.out f65f6f1
ql/src/test/results/clientpositive/spark/join9.q.out 92f0237
ql/src/test/results/clientpositive/spark/join_filters_overlap.q.out d63b4f8
ql/src/test/results/clientpositive/spark/join_map_ppr.q.out 086a05a
ql/src/test/results/clientpositive/spark/list_bucket_dml_2.q.java1.7.out
e38ccf8
ql/src/test/results/clientpositive/spark/load_dyn_part8.q.out 0adeabe
ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out fbc992c
ql/src/test/results/clientpositive/spark/mapjoin_mapjoin.q.out 65a7d06
ql/src/test/results/clientpositive/spark/optimize_nullscan.q.out 61ab311
ql/src/test/results/clientpositive/spark/outer_join_ppr.q.java1.7.out 1dd6822
ql/src/test/results/clientpositive/spark/pcr.q.out 0489117
ql/src/test/results/clientpositive/spark/ppd_join_filter.q.out cfb0a11
ql/src/test/results/clientpositive/spark/router_join_ppr.q.out fcb20ba
ql/src/test/results/clientpositive/spark/sample1.q.out 6c4f1a8
ql/src/test/results/clientpositive/spark/sample10.q.out 9a90ebd
ql/src/test/results/clientpositive/spark/sample2.q.out eac6fb4
ql/src/test/results/clientpositive/spark/sample4.q.out 8030f74
ql/src/test/results/clientpositive/spark/sample5.q.out b0cbe38
ql/src/test/results/clientpositive/spark/sample6.q.out 362608e
ql/src/test/results/clientpositive/spark/sample7.q.out 673984b
ql/src/test/results/clientpositive/spark/sample8.q.out 5d8e5bb
ql/src/test/results/clientpositive/spark/smb_mapjoin_11.q.out 6881804
ql/src/test/results/clientpositive/spark/smb_mapjoin_12.q.out 50bc19e
ql/src/test/results/clientpositive/spark/smb_mapjoin_13.q.out a95a935
ql/src/test/results/clientpositive/spark/smb_mapjoin_15.q.out 3f7be95
ql/src/test/results/clientpositive/spark/stats0.q.out f588ff3
ql/src/test/results/clientpositive/spark/stats12.q.out 0e25ac1
ql/src/test/results/clientpositive/spark/stats13.q.out 4934aec
ql/src/test/results/clientpositive/spark/stats3.q.out dd3a95b
ql/src/test/results/clientpositive/spark/transform_ppr1.q.out 0f5f115
ql/src/test/results/clientpositive/spark/transform_ppr2.q.out 704b092
ql/src/test/results/clientpositive/spark/union_ppr.q.out 61e557b
ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out eed14f3
ql/src/test/results/clientpositive/stats0.q.out 6e068dc
ql/src/test/results/clientpositive/stats11.q.out e51f049
ql/src/test/results/clientpositive/stats12.q.out f8aa4d0
ql/src/test/results/clientpositive/stats13.q.out 10ecfd2
ql/src/test/results/clientpositive/stats3.q.out dd3a95b
ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out
aed93b5
ql/src/test/results/clientpositive/temp_table_options1.q.out 01cc978
ql/src/test/results/clientpositive/tez/auto_sortmerge_join_1.q.out 0854036
ql/src/test/results/clientpositive/tez/auto_sortmerge_join_11.q.out b639547
ql/src/test/results/clientpositive/tez/auto_sortmerge_join_12.q.out 05b96be
ql/src/test/results/clientpositive/tez/auto_sortmerge_join_2.q.out c3bf80b
ql/src/test/results/clientpositive/tez/auto_sortmerge_join_3.q.out 605c207
ql/src/test/results/clientpositive/tez/auto_sortmerge_join_4.q.out 0a0e66e
ql/src/test/results/clientpositive/tez/auto_sortmerge_join_5.q.out a33f86e
ql/src/test/results/clientpositive/tez/auto_sortmerge_join_7.q.out 41ee47a
ql/src/test/results/clientpositive/tez/auto_sortmerge_join_8.q.out a28af9c
ql/src/test/results/clientpositive/tez/bucket2.q.out 9536ed0
ql/src/test/results/clientpositive/tez/bucket3.q.out 3427474
ql/src/test/results/clientpositive/tez/bucket4.q.out ca3584e
ql/src/test/results/clientpositive/tez/ctas.q.out d576fa5
ql/src/test/results/clientpositive/tez/disable_merge_for_bucketing.q.out
dcffd87
ql/src/test/results/clientpositive/tez/filter_join_breaktask.q.out a309a87
ql/src/test/results/clientpositive/tez/mapjoin_mapjoin.q.out e11c050
ql/src/test/results/clientpositive/tez/metadataonly1.q.out e017da3
ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out 67ccb38
ql/src/test/results/clientpositive/tez/sample1.q.out 7bc668e
ql/src/test/results/clientpositive/tez/transform_ppr1.q.out a76bd0f
ql/src/test/results/clientpositive/tez/transform_ppr2.q.out 0b59a9c
ql/src/test/results/clientpositive/tez/vectorized_ptf.q.out d90aa63
ql/src/test/results/clientpositive/transform_ppr1.q.out 4e00546
ql/src/test/results/clientpositive/transform_ppr2.q.out 9811313
ql/src/test/results/clientpositive/truncate_column_list_bucket.q.out e8a4fc2
ql/src/test/results/clientpositive/udf_explode.q.out 6ba82f0
ql/src/test/results/clientpositive/udtf_explode.q.out 892b2bd
ql/src/test/results/clientpositive/union22.q.out 672fa77
ql/src/test/results/clientpositive/union24.q.out 842e4a4
ql/src/test/results/clientpositive/union_ppr.q.out 26f353b
ql/src/test/results/clientpositive/varchar_serde.q.out 5f3f2ed
ql/src/test/results/clientpositive/vectorized_ptf.q.out 75c8144
serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 38e8b77
Diff: https://reviews.apache.org/r/30422/diff/
Testing
-------
Existing tests.
Thanks,
Ashutosh Chauhan
