> On Jan. 27, 2015, 6:20 a.m., Brock Noland wrote: > > Hi Dong, > > > > This looks great!! > > > > Can we rename "RuntimeTimeout" to "Deadline" so it's more clear what this > > is? Also it appears we are taking the timeout configuration from local > > config. Do you plan on having the client setting the timeout value they are > > using somehow? Clients might use varying timeouts. > > > > Thanks again! I really like this change. > > > > Brock
Thanks for your review! Brock About client setting the timeout, a SessionPropertiesListener extending MetaStoreEventListener was added in this patch for handling client requesting timeout change. I think this could introduce code change least. How does that sound? For usage, client could use "set metaconf:hive.metastore.server.running.method.timeout 500s" to change timeout. The call stack in HS2/HMS is like SetProcesser.setVariable -> Hive.setMetaConf -> HiveMetaStoreClient.setMetaConf -> HiveMetaStore.HMSHandler.setMetaConf -> notify added listeners -> SessionPropertiesListener.onConfigChange. A test was added in TestHiveMetaStoreTimeout.testResetTimeout. Since there is no interface change for users and they just need to set the conf parameter in their session, maybe it is necessary to mention the set timeout command in wiki doc for user knowing it. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review69751 ----------------------------------------------------------- On Jan. 22, 2015, 8:22 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29807/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 8:22 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-9253: MetaStore server should support timeout for long running requests > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5e00575 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > caad948 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 564ac8b > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java > 01ad36a > metastore/src/java/org/apache/hadoop/hive/metastore/RuntimeTimeout.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/RuntimeTimeoutException.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java > PRE-CREATION > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java > PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestRuntimeTimeout.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29807/diff/ > > > Testing > ------- > > UT passed > > > Thanks, > > Dong Chen > >
