----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30162/#review69176 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/LocalSparkJobMonitor.java <https://reviews.apache.org/r/30162/#comment113786> Need a space before { - Xuefu Zhang On Jan. 22, 2015, 12:12 p.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30162/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 12:12 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-9370 > https://issues.apache.org/jira/browse/HIVE-9370 > > > Repository: hive-git > > > Description > ------- > > On RSC mode, monitor based on new remote job state instead of Spark job > state, as we could ge more detail information through the former > interface.For example, the STARTED state of remote job indicate that remote > job has submitted to RemoteDriver and related is going to submitted on the > next, so we would not timeout after this state detected although we may not > get spark job info yet. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > 32e5530 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java > 30a00a7 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java a4554ac > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/LocalSparkJobMonitor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > 4f54612 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobRef.java > fe2d9f7 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/LocalSparkJobRef.java > f28c02b > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobRef.java > a2707d1 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java > a8ac482 > > Diff: https://reviews.apache.org/r/30162/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > >
