[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283057#comment-14283057
 ] 

Alan Gates commented on HIVE-9404:
----------------------------------

+1, the changes look fine.  

As a side note, I'm wondering if in isRetryable the line 
{{if("08S01".equalsIgnoreCase(sqlException.getSQLState()))}} shouldn't include 
a check whether dbProduct is MySQL (I know I should have said this in the 
review of HIVE-9390 instead).

> NPE in 
> org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-9404
>                 URL: https://issues.apache.org/jira/browse/HIVE-9404
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 0.15.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>         Attachments: HIVE-9404.patch
>
>
> {noformat}
> Caused by: java.lang.NullPointerException
>       at 
> org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
>       at 
> org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
>       at 
> org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
>       at 
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to