> On Ene. 10, 2015, 5:31 a.m., cheng xu wrote: > > itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java, > > line 40 > > <https://reviews.apache.org/r/28964/diff/3/?file=814782#file814782line40> > > > > Can you sort the import statements in alphabetical order?
Is this necessary? The IDE adds the imports in alphabetical order, but it sometimes puts some at the end, like in this case of java.io.*. > On Ene. 10, 2015, 5:31 a.m., cheng xu wrote: > > itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java, > > line 161 > > <https://reviews.apache.org/r/28964/diff/3/?file=814782#file814782line161> > > > > Can we add some space here before and after the definition for public > > method and some annotations for them? I removed the init() method from the interface. > On Ene. 10, 2015, 5:31 a.m., cheng xu wrote: > > itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java, > > line 290 > > <https://reviews.apache.org/r/28964/diff/3/?file=814782#file814782line290> > > > > No need to break line here. I broke it for better reading here. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28964/#review67581 ----------------------------------------------------------- On Ene. 9, 2015, 6:38 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28964/ > ----------------------------------------------------------- > > (Updated Ene. 9, 2015, 6:38 p.m.) > > > Review request for hive, Brock Noland and cheng xu. > > > Bugs: HIVE-8121 > https://issues.apache.org/jira/browse/HIVE-8121 > > > Repository: hive-git > > > Description > ------- > > This is a new tool used to test ORC & PARQUET file format performance. > > > Diffs > ----- > > itests/hive-jmh/pom.xml PRE-CREATION > > itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java > PRE-CREATION > itests/pom.xml 0a154d6eb8c119e4e6419777c28b59b9d2108ba0 > > Diff: https://reviews.apache.org/r/28964/diff/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
