[ https://issues.apache.org/jira/browse/HIVE-9367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277642#comment-14277642 ]
Xuefu Zhang commented on HIVE-9367: ----------------------------------- Thanks for the explanation. This is a shim class, so we are okay. Patch looks good to me. One note though, is that prune() method seems no longer needed. Could you remove it? > CombineFileInputFormatShim#getDirIndices is expensive > ----------------------------------------------------- > > Key: HIVE-9367 > URL: https://issues.apache.org/jira/browse/HIVE-9367 > Project: Hive > Issue Type: Improvement > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Attachments: HIVE-9367.1.patch > > > [~lirui] found out that we spent quite some time on > CombineFileInputFormatShim#getDirIndices. Looked into it and it seems to me > we should be able to get rid of this method completely if we can enhance > CombineFileInputFormatShim a little. -- This message was sent by Atlassian JIRA (v6.3.4#6332)