----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29625/#review67980 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java <https://reviews.apache.org/r/29625/#comment112070> Could you change joinSrc to leftInputJoin or something similar? Also the get/set method names? JoinSrc is rather confusing ( I know thats what they had originally). - John Pullokkaran On Jan. 13, 2015, 7:07 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29625/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 7:07 p.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-9200 > https://issues.apache.org/jira/browse/HIVE-9200 > > > Repository: hive-git > > > Description > ------- > > CBO (Calcite Return Path): Inline Join, Properties > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java > 2e771ec60851113ef9a717c87e142ca70bc53c07 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java > 03742d436930526ff2db15d6ed159f4f0d7136f0 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java > eba35f583fd077f492811b6231dfd59e8b05ea58 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java > 264d3f0b0ad80163831179b57aefdd4a4c5cc647 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java > 7ab35eec5987c78dee0349431e06ee65a20ee2cd > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > ae0addcee51abf08904872ddf8dfb2c12e71a9e0 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java > 9238e0e541b748f5e45fe572e6b4575cc3299b7f > ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java > 828f87c1f043324b0432bcc7c1f461267e19d0a6 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java > 5291851b105730490033ff91e583ee44022ed24f > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java > ea06503b0377ffb98f2583869e2c51ac1ea4e398 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java > 11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java > 8a0c47477718141cab85a4d6f71070117372df91 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java > bed95faa9bf072563262292931cc4b7d7cb034b3 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java > c52f7530b10c81a662118d2cb43599c82f7dbb4f > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java > 33ef581a97768d6391c67558e768d10e46a366f2 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java > 9c26907544ad8ced31d5cf47ed27c8a240f93925 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java > 6f92b13ff7c1cdd4c651f5e1bff42626dee52750 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java > 037983434d2ab5ce6c8f523b89370ca68cd98e27 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java > f62ad6cd109755f60e0e673a679c5107f91c43c0 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java > ffe11a0f0d2ee8f63b124b13275aca8de4704d8b > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java > d00c48d8df3958a0a274aa30f2b999a98a6256c8 > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java > 8215c26f48f1611d3c64f6df5bcfac02069e3a67 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 > ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java > da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java > 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 > ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java > c144d8c05c73025ba33b300229125e000074930e > ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java > 9f8c0918179d9226e36cecc3bd955946d6b5fe98 > > Diff: https://reviews.apache.org/r/29625/diff/ > > > Testing > ------- > > Existing tests. > > > Thanks, > > Jesús Camacho Rodríguez > >
