[ 
https://issues.apache.org/jira/browse/HIVE-9272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276163#comment-14276163
 ] 

Sushanth Sowmyan commented on HIVE-9272:
----------------------------------------

The .pm changes look reasonable to me. It's basically checking type of 
argument(s), and appropriately utf8-decoding them, so that they may be compared 
for equivalence.

I had some difficulty using git apply with this patch, but looks like standard 
unix patch with a "patch -p1" itself works. Since this is a patch that purely 
affects e2e tests, there are no expected changes to the unit test tree itself, 
but I'm still going to go ahead and set this as patch-available and let the 
build run, in case the presence of unicode files gives some of the build tools 
a hiccup. If all of that passes, I can go ahead and commit it.

Also, [~asreekumar], could you respond to Eugene's first question in the 
meanwhile?

> Tests for utf-8 support
> -----------------------
>
>                 Key: HIVE-9272
>                 URL: https://issues.apache.org/jira/browse/HIVE-9272
>             Project: Hive
>          Issue Type: Test
>          Components: Tests, WebHCat
>            Reporter: Aswathy Chellammal Sreekumar
>            Assignee: Aswathy Chellammal Sreekumar
>            Priority: Minor
>         Attachments: HIVE-9272.1.patch, HIVE-9272.patch
>
>
> Including some test cases for utf8 support in webhcat. The first four tests 
> invoke hive, pig, mapred and streaming apis for testing the utf8 support for 
> data processed, file names and job name. The last test case tests the 
> filtering of job name with utf8 character



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to