[ 
https://issues.apache.org/jira/browse/HIVE-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dong Chen updated HIVE-9283:
----------------------------
    Description: 
NO PRECOMMIT TESTS

I found some test cases .q file could be improved by:

1. change the table location from {{/user/hive/warehouse...}} to 
{{/build/ql/test/data/warehouse/...}}.
The reason is that the default warehouse dir defined in QTestUtil is the latter 
one, and the partial mask is based on it. I think it is better to make test 
cases consistent with code. Also the .hive_staging location we want in .out 
will be shown then.

2. add cleanup at the end.
drop table and delete key. Otherwise, some cases will fail caused by cannot 
create existed key. (Put in HIVE-9286)

  was:
I found some test cases .q file could be improved by:

1. change the table location from {{/user/hive/warehouse...}} to 
{{/build/ql/test/data/warehouse/...}}.
The reason is that the default warehouse dir defined in QTestUtil is the latter 
one, and the partial mask is based on it. I think it is better to make test 
cases consistent with code. Also the .hive_staging location we want in .out 
will be shown then.

2. add cleanup at the end.
drop table and delete key. Otherwise, some cases will fail caused by cannot 
create existed key. (Put in HIVE-9286)


> Improve encryption related test cases
> -------------------------------------
>
>                 Key: HIVE-9283
>                 URL: https://issues.apache.org/jira/browse/HIVE-9283
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Dong Chen
>            Assignee: Dong Chen
>         Attachments: HIVE-9283.patch
>
>
> NO PRECOMMIT TESTS
> I found some test cases .q file could be improved by:
> 1. change the table location from {{/user/hive/warehouse...}} to 
> {{/build/ql/test/data/warehouse/...}}.
> The reason is that the default warehouse dir defined in QTestUtil is the 
> latter one, and the partial mask is based on it. I think it is better to make 
> test cases consistent with code. Also the .hive_staging location we want in 
> .out will be shown then.
> 2. add cleanup at the end.
> drop table and delete key. Otherwise, some cases will fail caused by cannot 
> create existed key. (Put in HIVE-9286)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to