[ https://issues.apache.org/jira/browse/HIVE-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267357#comment-14267357 ]
Dong Chen commented on HIVE-9283: --------------------------------- Good suggestion! This can make the piece of code focused, and easy to revert or review. Thank [~Ferd] I put the 2nd point in HIVE-9268. > Improve encryption related test cases > ------------------------------------- > > Key: HIVE-9283 > URL: https://issues.apache.org/jira/browse/HIVE-9283 > Project: Hive > Issue Type: Sub-task > Reporter: Dong Chen > Assignee: Dong Chen > > I found some test cases .q file could be improved by: > 1. change the table location from {{/user/hive/warehouse...}} to > {{/build/ql/test/data/warehouse/...}}. > The reason is that the default warehouse dir defined in QTestUtil is the > latter one, and the partial mask is based on it. I think it is better to make > test cases consistent with code. Also the .hive_staging location we want in > .out will be shown then. > 2. add cleanup at the end. > drop table and delete key. Otherwise, some cases will fail caused by cannot > create existed key. -- This message was sent by Atlassian JIRA (v6.3.4#6332)