[ https://issues.apache.org/jira/browse/HIVE-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262704#comment-14262704 ]
Lefty Leverenz commented on HIVE-6173: -------------------------------------- Doc: Strictly speaking, the TODOC13 label should be removed because --hiveconf has been documented. The release note should also be revised. But TODOC13 is still here for some followup issues which really belong in a separate jira. Maybe we can wrap them up here, though. {quote} > 2. Is the autoCommit default false as shown in BeeLineOpts.java or true as > shown in the SQLLine doc? Hive doesn't support transaction or rollback concept. (It always auto-commit upon success.) As to this prop, it doesn't really matter as far as Hive is concerned. (Beeline is able to connect to other databases, in which case this may makes a difference.) {quote} Now that Hive has transactions, is Beeline's autoCommit useful? If not, should it be removed from the wiki or explained away? {quote} > 4. What is the default for numberFormat? BeeLineOpts.java says "default" > but I don't know what that means. could you check what SQLLine doc says? {quote} The SQLLine doc doesn't cover numberFormat. Does it use the default for Java's DecimalFormat class? (See links below.) {quote} > 7. Should any of these options be documented? <see list below> SQLLine has a lot of properties, a little overwhelming. I'd think we should probably document only that's closely tied with Hive and refer user to SQLLine doc for others. {quote} Reply A: Then maybe some options should be removed from the wiki. At present only one option (historyfile) is in the SQLLine doc but not in the Beeline doc. Rather than direct readers to SQLLine for a single option, I'm inclined to add historyfile to the wiki. Reply B: The options listed in point 7 aren't covered by the SQLLine doc. They're in the code in BeeLineOpts but not in BeeLine.properties: showElapsedTime, maxHeight, timeout, trimScripts, allowMultiLineCommand. (Are they internal only?) Reference links: * [Beeline Command Options | https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Clients#HiveServer2Clients-BeelineCommandOptions] * [SQLLine documentation | http://sqlline.sourceforge.net] * [DecimalFormat class | http://docs.oracle.com/javase/7/docs/api/java/text/DecimalFormat.html] * [DecimalFormat constructor| http://docs.oracle.com/javase/7/docs/api/java/text/DecimalFormat.html#DecimalFormat()]: "To obtain standard formats for a given locale, use the factory methods on NumberFormat such as getNumberInstance. These factories will return the most appropriate sub-class of NumberFormat for a given locale." > Beeline doesn't accept --hiveconf option as Hive CLI does > --------------------------------------------------------- > > Key: HIVE-6173 > URL: https://issues.apache.org/jira/browse/HIVE-6173 > Project: Hive > Issue Type: Improvement > Components: CLI > Affects Versions: 0.10.0, 0.11.0, 0.12.0 > Reporter: Xuefu Zhang > Assignee: Xuefu Zhang > Labels: TODOC13 > Fix For: 0.13.0 > > Attachments: HIVE-6173.1.patch, HIVE-6173.2.patch, HIVE-6173.patch > > > {code} > > beeline -u jdbc:hive2:// --hiveconf a=b > Usage: java org.apache.hive.cli.beeline.BeeLine > {code} > Since Beeline is replacing Hive CLI, it should support this command line > option as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)