[
https://issues.apache.org/jira/browse/HIVE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109260#comment-13109260
]
jirapos...@reviews.apache.org commented on HIVE-2457:
-----------------------------------------------------
bq. On 2011-09-21 00:26:28, Carl Steinbach wrote:
bq. >
Thanks for the review!
bq. On 2011-09-21 00:26:28, Carl Steinbach wrote:
bq. > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 892
bq. > <https://reviews.apache.org/r/1989/diff/1/?file=44442#file44442line892>
bq. >
bq. > Please add this configuration property to HiveConf and
hive-default.xml
Does Hive have the concept of private configuration properties? This is one
that would set by SerDe's, not by users, which is why I didn't add it to
HiveConf/hive-default.xml.
bq. On 2011-09-21 00:26:28, Carl Steinbach wrote:
bq. > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java,
line 28
bq. > <https://reviews.apache.org/r/1989/diff/1/?file=44444#file44444line28>
bq. >
bq. > In addition to the unit test it would also be nice to test this via
TestCliDriver.
bq. >
bq. > It should be possible to verify this from the CLI by doing something
like this:
bq. >
bq. >
bq. > -- Set the filename suffix property. Then create a new table and
stream
bq. > -- data into it. Then use the dfs cat command to dump the contents of
bq. > -- the raw files in the warehouse to stdout
bq. > hive> dfs -cat
${hiveconf:hive.metastore.warehouse.dir}/<tablename>/*.avro;
Good idea. I'll look at adding a test like this.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1989/#review1982
-----------------------------------------------------------
On 2011-09-20 22:28:53, Carl Steinbach wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1989/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-20 22:28:53)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Review for HIVE-2457
bq.
bq.
bq. This addresses bug HIVE-2457.
bq. https://issues.apache.org/jira/browse/HIVE-2457
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
1173340
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1173340
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java
1173340
bq. trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1989/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Carl
bq.
bq.
> Files in Avro-backed Hive tables do not have a ".avro" extension
> ----------------------------------------------------------------
>
> Key: HIVE-2457
> URL: https://issues.apache.org/jira/browse/HIVE-2457
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Serializers/Deserializers
> Reporter: Tom White
> Assignee: Tom White
> Attachments: HIVE-2457.patch
>
>
> When using the Avro SerDe (see HIVE-895, https://github.com/jghoman/haivvreo)
> the files created for an Avro table do not have a ".avro" extension, which
> causes problems for tools like Avro MapReduce or Sqoop which expect the
> extension.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
