[ 
https://issues.apache.org/jira/browse/HIVE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247599#comment-14247599
 ] 

Hive QA commented on HIVE-9109:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12687317/HIVE-9109.patch

{color:green}SUCCESS:{color} +1 6703 tests passed

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2083/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2083/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2083/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12687317 - PreCommit-HIVE-TRUNK-Build

> Add support for Java 8 specific q-test out files
> ------------------------------------------------
>
>                 Key: HIVE-9109
>                 URL: https://issues.apache.org/jira/browse/HIVE-9109
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Mohit Sabharwal
>            Assignee: Mohit Sabharwal
>         Attachments: HIVE-9109.patch
>
>
> Hash function differences between Java 7 and Java 8 lead to result order 
> differences. While we have been able to fix a good number by converting hash 
> maps to insert order hash maps, there are several cases where doing so is 
> either not possible (because changes originate in external APIs) or change 
> leads to even more out file differences.
> For example:
> (1) In TestCliDriver.testCliDriver_varchar_udf1, for the following query:
> {code}
> select
>   str_to_map('a:1,b:2,c:3',',',':'),
>   str_to_map(cast('a:1,b:2,c:3' as varchar(20)),',',':')
> from varchar_udf_1 limit 1;”)
> {code}
> the {{StandardMapObjectInspector}} used in {{LazySimpleSerDe}} to serialize 
> the final output uses a {{HashMap}}. Changing it to {{LinkedHashMap}} will 
> lead to several other q-test output differences.
> (2) In TestCliDriver.testCliDriver_parquet_map_null, data with {{map}} column 
> is read from an Avro table into a Parquet table. Avro API, specifically 
> {{GenericData.Record}} uses {{HashMap}} and returns data in different order.
> This patch adds supports to specify a hint called 
> {{JAVA_VERSION_SPECIFIC_OUTPUT}} which may be added to a q-test, only if 
> different outputs are expected for Java 7 and Java 8.  
> Under Java 7, test output file has (original) ".out" extension. 
> Under Java 8, test output file has ".java8.out" extension.
> If hint is not added, we continue to generate a single ".out" file for the 
> test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to