----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28973/ -----------------------------------------------------------
(Updated Dec. 13, 2014, 11:52 p.m.) Review request for hive, Ashutosh Chauhan and John Pullokkaran. Changes ------- add one more test case Repository: hive-git Description ------- Here is the the way to reproduce with q test: select key from (select '1' as key from src union all select key from src)tab group by key; will give OK NULL 1 This is not correct as src contains many other keys. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java 8551a5b ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanTaskDispatcher.java 957c327 ql/src/test/queries/clientpositive/metadataOnlyOptimizer.q PRE-CREATION ql/src/test/results/clientpositive/metadataOnlyOptimizer.q.out PRE-CREATION ql/src/test/results/clientpositive/optimize_nullscan.q.out 02636ba Diff: https://reviews.apache.org/r/28973/diff/ Testing ------- Thanks, pengcheng xiong