> On Dec. 12, 2014, 12:36 a.m., Xuefu Zhang wrote: > > Patch looks good. Two questions: > > 1. Are the changes applicable to other engine (harmless at least)? If so, > > maybe we should make the changes in trunk. > > 2. Adding a new alias to alias map seems a little hacky. Is it possible > > that we just replace the old alias with the new alias w/o keeping a mapping > > between them?
1. Yes, it is harmless to other engines although they don't use it. 2. I perfer to update it in place too. I was wondering if a mapjoin can't be converted to bucket mapjoin later, will it cause any problem to change it? > On Dec. 12, 2014, 12:36 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java, > > line 445 > > <https://reviews.apache.org/r/28972/diff/1/?file=789850#file789850line445> > > > > Is this spark specific, or also applicable in general? If it doesn't > > break things, we should just remove the "spark" check. Ok. Let me remove this check. > On Dec. 12, 2014, 12:36 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java, line > > 413 > > <https://reviews.apache.org/r/28972/diff/1/?file=789852#file789852line413> > > > > This changes seems not required for Spark, right? It is needed for Spark, for mapjoin hint support. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28972/#review64824 ----------------------------------------------------------- On Dec. 11, 2014, 11:07 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28972/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 11:07 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-9081 > https://issues.apache.org/jira/browse/HIVE-9081 > > > Repository: hive-git > > > Description > ------- > > Updated the posToAliasMap in case any alias is changed. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java > 70c23a6 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketJoinProcCtx.java > 911b1c8 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java > 773c827 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java > 7a716a9 > > Diff: https://reviews.apache.org/r/28972/diff/ > > > Testing > ------- > > With this patch, the auto_sortmerge_join_9.q is ok with HIVE-8639. Otherwise, > it fails. > > > Thanks, > > Jimmy Xiang > >
