> On Dec. 9, 2014, 8:28 p.m., Xuefu Zhang wrote: > > Patch looks a good. A test case with multiple map joins in one work would > > be awesome.
Let me add a test case. Thanks. > On Dec. 9, 2014, 8:28 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, > > line 94 > > <https://reviews.apache.org/r/28864/diff/1/?file=787121#file787121line94> > > > > There is no need to be "lazy" here. We can just instantiate it here. Just trying to avoid creating an object in case not needed. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28864/#review64428 ----------------------------------------------------------- On Dec. 9, 2014, 7:41 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28864/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 7:41 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-9042 > https://issues.apache.org/jira/browse/HIVE-9042 > > > Repository: hive-git > > > Description > ------- > > In one spark work, there could be multiple mapjoin operators, but only one > could be bucket mapjoin. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java > 6977abc > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java > ef04885 > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkBucketMapJoinContext.java > 2976c3a > > Diff: https://reviews.apache.org/r/28864/diff/ > > > Testing > ------- > > Unit test. > > > Thanks, > > Jimmy Xiang > >
