----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1933/#review1956 -----------------------------------------------------------
Ship it! - Ning On 2011-09-17 00:14:50, Kevin Wilfong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1933/ > ----------------------------------------------------------- > > (Updated 2011-09-17 00:14:50) > > > Review request for hive and Ning Zhang. > > > Summary > ------- > > The information that would be useful for categorizing queries is clearest in > the Semantic Analyzer, when the data from the Parser is interpreted. I added > a new class which is designed to collect that data here, and place it > ultimately in the QueryPlan where it will be available to hooks. > > The information I collect is whether or not the query has the following > clauses: > Join > Group By > Order By > Sort By > Group By after a Join clause > > Also, I store whether or not a script is used for mapping or reducing. > > > This addresses bug HIVE-2453. > https://issues.apache.org/jira/browse/HIVE-2453 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 1170719 > trunk/ql/src/java/org/apache/hadoop/hive/ql/QueryProperties.java > PRE-CREATION > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 1170719 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1170719 > > trunk/ql/src/test/org/apache/hadoop/hive/ql/hooks/CheckQueryPropertiesHook.java > PRE-CREATION > trunk/ql/src/test/queries/clientpositive/query_properties.q PRE-CREATION > trunk/ql/src/test/results/clientpositive/query_properties.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/1933/diff > > > Testing > ------- > > I added a new test, which runs a variety of queries, such that each of the > flags in QueryProperties is set by at least one query, and also some are set > in combinations. > I also added a hook which prints the contents of QueryProperties to error on > the console. > > I checked the output in the results file and verified it matched what I > expected. > > > Thanks, > > Kevin > >
